Skip to content

sp_QuickieStore: fix @find_high_impact output formatting#699

Merged
erikdarlingdata merged 5 commits intodevfrom
feature/find-high-impact-fixes
Mar 23, 2026
Merged

sp_QuickieStore: fix @find_high_impact output formatting#699
erikdarlingdata merged 5 commits intodevfrom
feature/find-high-impact-fixes

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

Summary

  • query_sql_text now uses the processing-instruction XML pattern (clickable in SSMS, no > encoding issues), matching the existing pattern used in the main output path
  • top_waits column and its LEFT JOIN are conditionally omitted when Query Store wait stats aren't available (SQL 2016 or waits not enabled) — previously showed a NULL column

Test plan

  • Deployed and tested on SQL2022 (waits present, column shown)
  • Deployed and tested on SQL2016 (waits unavailable, column omitted)
  • Test on sql2017, sql2019, sql2025

🤖 Generated with Claude Code

Darling Data and others added 5 commits March 2, 2026 18:17
Fix CI loop: add [skip ci] to automation commit
- query_sql_text now uses processing-instruction XML pattern (clickable
  in SSMS without encoding issues), matching the main output path
- top_waits column and LEFT JOIN conditionally omitted when Query Store
  wait stats are unavailable (SQL 2016 or waits not enabled) instead of
  showing a NULL column
- Updated help text to reflect conditional top_waits behavior

Tested on SQL2022 (waits present) and SQL2016 (waits omitted).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit 1a13655 into dev Mar 23, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant