Skip to content

Add override.shanghaiTime flag#6414

Merged
yperbasis merged 1 commit into
develfrom
override_shanghai
Dec 23, 2022
Merged

Add override.shanghaiTime flag#6414
yperbasis merged 1 commit into
develfrom
override_shanghai

Conversation

@yperbasis

@yperbasis yperbasis commented Dec 23, 2022

Copy link
Copy Markdown
Member

and remove --override.terminaltotaldifficulty & --override.mergeNetsplitBlock

@yperbasis yperbasis merged commit 4931f11 into devel Dec 23, 2022
@yperbasis yperbasis deleted the override_shanghai branch December 23, 2022 16:06
@moraesjeremias

Copy link
Copy Markdown

@yperbasis Is this change related to EIP-4444?
Why did you remove --override.terminaltotaldifficulty flag for Shanghai HF? Is this related to one of Shanghai HF EIPs ?
I appreciate your help!

@yperbasis

yperbasis commented Jan 27, 2023

Copy link
Copy Markdown
Member Author

@yperbasis Is this change related to EIP-4444? Why did you remove --override.terminaltotaldifficulty flag for Shanghai HF? Is this related to one of Shanghai HF EIPs ? I appreciate your help!

I removed --override.terminaltotaldifficulty because it's a means to override when The Merge happens and The Merge has happened on all Ethereum networks already. Removing it is not necessarily related to Shanghai – it's just a clean-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants