eth_gasPrice performance tweaks#6016
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code news up an oracle for every call so existing cache checks always came back as 0. Moved cache up a layer and pass in via the new
gasprice.Cacheinterface. Looked at putting the oracle instance onto the ethApi itself to re-use it that way, but the backend transaction made it a little hard work as we can't re-use that. This seemed cleaner but happy to take feedback.Locally takes me from ±2.5k rps to ±43k rps so quite a difference there. (k6 with 1000 virtual users)