[BSC] support for Moran fork#5696
Merged
Merged
Conversation
|
@14MR hi you forgot the bsc chapel testnet |
|
Does this commit cover chapel testnet? |
Contributor
Author
|
@sjlee1125 @masayil updated the chainspec |
Contributor
|
@14MR you're missing this part of the patch: diff --git a/core/vm/evm.go b/core/vm/evm.go
index c671e5c3e..33d0fb5ad 100644
--- a/core/vm/evm.go
+++ b/core/vm/evm.go
@@ -45,6 +45,8 @@ type (
func (evm *EVM) precompile(addr common.Address) (PrecompiledContract, bool) {
var precompiles map[common.Address]PrecompiledContract
switch {
+ case evm.chainRules.IsMoran:
+ precompiles = PrecompiledContractsIsMoran
case evm.chainRules.IsNano:
precompiles = PrecompiledContractsNano
case evm.chainRules.IsBerlin: |
Contributor
Author
Thank you, i also found a few missing parts in tests. Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings support for BSC Moran fork