execution: tidy move some bal selfdestruct tests to engine_api_bal_test#21599
Conversation
…e-bal_selfdestruct_systemaddress_test
Move SELFDESTRUCT/SystemAddress BAL tests to the engine-API testerSummaryTest-only refactor. Moves the three EIP-7928 SELFDESTRUCT-beneficiary BAL These tests guard the regression fixed in #21333: per EIP-7928 a Changes
Notes
Test plan / TDD verification
The red/green split (only the zero-balance SystemAddress case fails) matches
|
There was a problem hiding this comment.
Pull request overview
Moves the BAL SELFDESTRUCT beneficiary regression tests (introduced in the follow-up to #21333 / EIP-7928) from the execmodule/blockgen-based harness into the Engine API BAL test suite so they run through the EngineApiTester/BuildCanonicalBlock path that validates proposer vs parallel-executor BAL consistency.
Changes:
- Remove the standalone
execution/execmoduleregression test file for SELFDESTRUCT→SystemAddress/EOA BAL inclusion. - Reintroduce the same scenarios in
execution/engineapi/engine_api_bal_test.gousingEngineApiTester, plus small local helpers for CREATE+SELFDESTRUCT initcode testing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| execution/execmodule/bal_selfdestruct_systemaddress_test.go | Removed: blockgen-based BAL SELFDESTRUCT beneficiary regression tests. |
| execution/engineapi/engine_api_bal_test.go | Added: Engine API-based versions of the BAL SELFDESTRUCT beneficiary regression tests and supporting helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
minor tidy follow up to #21333 to move the tests to be EngineApiTester based
should've done it back then but was in a rush to fix the issue