rpc/jsonrpc: encode executionWitness headers as RLP#21543
Merged
awskii merged 1 commit intoMay 31, 2026
Conversation
The headers field returned JSON header objects. The canonical stateless-witness format carries RLP-encoded headers, which is what a stateless verifier consumes. Encode each header with rlp.EncodeToBytes and change the field type to []hexutil.Bytes. This diverges from Geth's debug_executionWitness, which returns header objects; the target here is the canonical witness format. Verified against the EEST zkevm@v0.4.0 corpus: header hashes match (RLP round-trips), no regressions.
lupin012
approved these changes
May 31, 2026
Member
|
@awskii it was merged not into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return
headersas RLP-encoded bytes instead of JSON header objects, matching the canonical stateless-witness format (Reth compatibility). Field type[]map[string]any→[]hexutil.Bytes; dropsmarshalWitnessHeader.Diverges from Geth's
debug_executionWitness(header objects) — deliberate; the target is Reth-canonical.Corpus (zkevm@v0.4.0): header hashes match (RLP round-trips), no regressions, no decode errors.
Re-raise of the earlier #21537 (its branch was lost). Stacked on #21532. Refs #20534.