rpc/jsonrpc: drop pre-state code already created in-block from witness#21539
Merged
Conversation
A pre-state contract whose code hash was already produced by an in-block CREATE earlier in the block does not need to be in the witness: a stateless verifier replays the CREATE and already holds that bytecode. Track code hashes written via UpdateAccountCode and skip the pre-state read of a hash already created. Order is implicit — writes flush at tx finalization, before later txs read — so a read preceding the create is still kept (the verifier needs it then). Fixes witness_codes_create_same_hash_then_read on the EEST zkevm@v0.4.0 corpus while keeping witness_keeps_prestate_code_read_even_if_later_created_with_same_hash; codes mismatches 11 -> 10, no regressions. Refs #21307, #20534.
AskAlexSharov
approved these changes
May 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pre-state contract whose code hash was already produced by an in-block CREATE is redundant in
codes— the verifier replays the CREATE and has the bytecode.Track hashes written via
UpdateAccountCode;ReadAccountCodeskips a pre-state read whose hash was already created. Writes flush at tx finalization, so a read before the create is still kept.Corpus (zkevm@v0.4.0): fixes
create_same_hash_then_read, keepskeeps_prestate_code_read_even_if_later_created_with_same_hash. codes mm 11→10, no regressions.Builds on #21518. Refs #20534.