execution/execmodule: use last known finalised hash for fcu finalisedBlockNum#21007
Merged
Conversation
mh0lt
reviewed
May 6, 2026
mh0lt
left a comment
Contributor
There was a problem hiding this comment.
Did you check this with the dev chain, which now runs caplin in dev mode. It looks like a start-up fix for that. Don't knwo if its necessary.
mh0lt
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to #20825
best to use the last known finalised hash from the db and not from the request, otherwise the logic can be circumvented by a bad request
also if there is no known finalised hash the finalisedBlockNum should be 0