[r3.4] db/version: enforce upper-bound file version check#20739
Merged
Conversation
## Problem Snapshot file-version checks only rejected files that were **too old**. Files that were **too new** passed the check and got read with the wrong parser. Example: binary supports up to `v2.1`, directory contains `v3.0-storage.0-32.efi` — opened silently, no error. ## Solution Check both bounds in `Versions.MustSupport` and fail fast: - **Too old** → suggests `erigon snapshots reset`. - **Too new** → suggests upgrading Erigon, or `erigon snapshots reset` to align. Logged once via `sync.Once` (parallel goroutines don't duplicate the banner), then panics. Callsites in `dirty_files.go` and `block_types.go` migrated; `VersionTooLowPanic` and its local twin deleted. Unit tests cover in-range, too-low, and too-high.
sudeepdino008
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #20722 to release/3.4.