ci: pin glamsterdam ethereum-package to 6.1.0 #20593
Merged
Merged
Conversation
Commit 835dd9b in ethpandaops/ethereum-package introduced GpuConfig, a Starlark built-in that requires Kurtosis CLI >=1.18.1. CI installs an older version so Starlark eval fails. Pin to e07503d (the commit just before the regression) until CI is upgraded to Kurtosis 1.18.1.
Commit 835dd9b on main introduced GpuConfig, a Starlark built-in that requires Kurtosis CLI >=1.18.1. CI installs an older version so Starlark eval fails at startup. Pin to the 6.1.0 release tag which has GLOAS support but not the breaking GpuConfig. Unpin once CI is on 1.18.1.
Contributor
There was a problem hiding this comment.
[SharovBot]
LGTM.
The pin is well justified and the comment captures the dependency clearly:
- picked up commit introducing
- that requires Kurtosis CLI
- current CI image/tooling is older, so Starlark evaluation breaks before the actual test logic runs
Pinning to is the right short-term stabilization until CI is upgraded, and the inline comment makes the rollback condition explicit.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.