execution/types/stateless: reject empty witness headers during decode#20432
Merged
awskii merged 3 commits intoApr 11, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a decode-time invariant check to the stateless witness RLP path to prevent accepting witnesses with zero headers (which can lead to later panics when code assumes Headers[0] exists), along with a regression test covering the empty-headers RLP decode case.
Changes:
- Reject RLP-decoded witnesses that contain no headers in
fromExtWitness. - Add a regression test that RLP-decoding an
extWitnesswith emptyHeadersfails with the expected error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
execution/types/stateless/encoding.go |
Adds validation during RLP decode to reject witnesses with an empty header list. |
execution/types/stateless/witness_test.go |
Adds a regression test asserting RLP decode fails when headers are missing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
be220ff to
4d7660f
Compare
4d7660f to
55d5e7b
Compare
awskii
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash path when decoding an empty stateless witness. Some downstream witness logic assumes at least one header is present and may access
Headers[0], so accepting an empty witness can lead to a panic later. The change adds a small validation infromExtWitnessto reject witnesses with no headers during decode, and includes a regression test for the RLP decode path.