Skip to content

execmodule, stageloop: apply ERIGON_IN_MEM_HISTORY flag to ExecV3 path#20270

Merged
sudeepdino008 merged 1 commit into
mainfrom
execmodule-inmem-history-exev3
Apr 1, 2026
Merged

execmodule, stageloop: apply ERIGON_IN_MEM_HISTORY flag to ExecV3 path#20270
sudeepdino008 merged 1 commit into
mainfrom
execmodule-inmem-history-exev3

Conversation

@sudeepdino008

Copy link
Copy Markdown
Member

Follow-up to #20245.

ProcessFrozenBlocks already respected the ERIGON_IN_MEM_HISTORY env flag, but the remaining SharedDomains creation sites did not. This applies the flag to:

  • StageLoopIteration — ExecV3 live execution path
  • ValidateChain — fork validation path
  • updateForkChoice — FCU path

Setting ERIGON_IN_MEM_HISTORY=false now disables in-memory history reads across all execution paths, not just frozen block processing.

ProcessFrozenBlocks already respected the env flag. Apply it to the
remaining SharedDomains creation sites:

- StageLoopIteration (ExecV3 live exec path)
- ValidateChain (fork validation path)
- updateForkChoice (FCU path)
@sudeepdino008 sudeepdino008 marked this pull request as ready for review April 1, 2026 12:57
@sudeepdino008 sudeepdino008 enabled auto-merge April 1, 2026 13:05
if err != nil {
return nil, err
}
doms.SetInMemHistoryReads(inMemHistoryReads)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #20245 doesn't have this change

@sudeepdino008 sudeepdino008 added this pull request to the merge queue Apr 1, 2026
Merged via the queue into main with commit 38bd89d Apr 1, 2026
38 of 63 checks passed
@sudeepdino008 sudeepdino008 deleted the execmodule-inmem-history-exev3 branch April 1, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants