cl: unskip BLS execution change test on Windows#20248
Merged
yperbasis merged 4 commits intoMay 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the BLS-to-execution-change service tests to run on Windows and to avoid cross-test coupling by isolating state/setup per subtest via t.Cleanup.
Changes:
- Removed the Windows-only skip so the BLS-to-execution-change service test runs on all platforms.
- Replaced the
testify/suitesetup/teardown with per-subtest setup usingt.Cleanup(restoring global function hooks and cancelling verifier context). - Refactored test cases to mutate real
CachingBeaconStatevalidator data instead of mocking a state reader.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AskAlexSharov
approved these changes
Apr 9, 2026
edd3f3d to
dd4cc3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the Windows skip from the BLS-to-execution-change service test, and isolate each case with cleanup-backed setup so the suite no longer relies on leaked verifier state.