[r3.3] ci: improve release workflow robustness and inline debian pkg build#20150
Merged
yperbasis merged 2 commits intoMar 25, 2026
Merged
Conversation
…build Cherry-pick of 38aca05 ([r3.4]) to release/3.3. - Improve release workflow robustness (early release existence check, artifact verification, non-fatal skopeo delete, GitHub App token for publish step) - Inline debian package build (removing separate reusable workflow file) - Fix debian control file heredoc inside for loop - Update docker actions to v4.0.0 (Node.js 24) - Pin actions/create-github-app-token to v2.2.1 SHA (Node.js 24) - Add disable_version_check input flag - Change checkout_ref default to 'release/x.x' (operator must set explicitly) Conflict resolution: publish-docker-image job had explicit artifact download steps in 3.3 that were already removed in 3.4 — dropped them to match the 3.4 inlined behavior.
…low backport Manual touch 1 — remove mcp from BINARIES: cmd/mcp does not exist in release/3.3 (intentionally excluded). The cherry-pick of 38aca05 did not add mcp (it was a separate prior commit on 3.4), so BINARIES is already correct. This commit documents the intentional exclusion. Manual touch 2 — reapply changes skipped by git auto-merge: The cherry-pick auto-resolved several sections by keeping 3.3's version due to context differences. Re-applied the following missing changes: - checkout_ref default: 'main' -> 'release/x.x' with [MANUAL EDIT REQUIRED] description (safety check: operator must set branch explicitly) - Add disable_version_check workflow input - Add 'Validate release version against db/version/app.go' step - Bump actions/checkout to @v6 (all occurrences) - Bump actions/upload-artifact to @v6 (build-release + test-release) - Bump actions/download-artifact to @v7 (test-release + publish-release)
yperbasis
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #19853 (originally cherry-picked to
release/3.4as38aca05899) torelease/3.3.reusable-release-build-debian-pkg.ymlworkflow fileactions/create-github-app-tokento v2.2.1 SHA (Node.js 24)disable_version_checkinput flagactions/checkout,upload-artifact,download-artifactto latest versionscheckout_refdefault to'release/x.x'— operator must set this manually (acts as a safety check to prevent accidentally building from wrong branch)3.3-specific adjustments (second commit)
mcpexcluded fromBINARIES—cmd/mcpdoes not exist inrelease/3.3; it was intentionally kept out of this branchcheckout_refdefault,disable_version_checkinput, version validation step, and all action version bumpsTest plan
release/3.3withperform_release=falseand verify the build-release + build-debian-pkg jobs complete successfullycheckout_refdefault shows'release/x.x'in the workflow dispatch UI (not'main')reusable-release-build-debian-pkg.ymlis gone and debian build runs inline