ci: Add path filtering to workflows and clarify RPC test failures#19064
ci: Add path filtering to workflows and clarify RPC test failures#19064Copilot wants to merge 8 commits into
Conversation
The consensus spec CI downloads test fixtures from GitHub releases via wget. Transient GitHub CDN errors (e.g. 502) cause the entire job to fail even though the code is fine. Split the wget into a separate download-spec Makefile target and CI step with continue-on-error, so a download failure produces a warning instead of blocking PRs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@copilot make it so the CI workflows don't run unless some relevant input changed that could make them matter |
Co-authored-by: anacrolix <988750+anacrolix@users.noreply.github.com>
Done in 2f8e836. Added path filtering to both CI workflows: ci.yml (Unit tests): Now skips when only dashboards, markdown files, docs, or backup workflow changes. test-integration-caplin.yml (Consensus spec): Only runs when This prevents unnecessary CI runs for documentation updates, dashboard changes, etc. |
|
@copilot specifically .github/workflows/test-kurtosis-assertoor.yml |
Co-authored-by: anacrolix <988750+anacrolix@users.noreply.github.com>
|
@copilot rebase on to main. can you use a path-ignore field common to both push and pull request? why ignore .github/workflows/backups-dashboards.yml. how did you determine the list of things to ignore. can you ignore any source files that don't affect test-kurtosis-assertoor.yml, or instead flip it to be only on files that do affect test-kurtosis-assertoor.yml? |
…paths list Co-authored-by: anacrolix <988750+anacrolix@users.noreply.github.com>
Done in 33a9ed8. Rebase on main: The base branch Common path field: GitHub Actions doesn't support YAML anchors/aliases for the Improved test-kurtosis-assertoor.yml: Switched from
Why backups-dashboards.yml was ignored: It was copied from test-all-erigon.yml pattern. The explicit |
|
This PR was confused, and the useful thing in it was already merged to main elsewhere. |
Investigated RPC integration test failures in commits 4da2654 and 633386c. The failures are false positives unrelated to this PR's consensus spec download tolerance changes.
Analysis
eth_simulateV1tests (test_02, test_03, test_09)cl/spectest/Makefile,.github/workflows/test-integration-caplin.yml, Windows build workflowsChanges Made
Path Filtering for CI Workflows
Added path-based filtering to CI workflows to prevent unnecessary runs when irrelevant files change:
paths-ignoreto skip runs when only dashboards, markdown files, docs, or backup workflows changepathsfilter to only run whencl/,erigon-lib/,go.mod,go.sum,Makefile, or the workflow itself changespaths-ignoreto explicitpathsallowlist. Only runs when Go source files (**/*.go), build dependencies (go.mod,go.sum,Makefile,Dockerfile), Kurtosis configurations (.github/workflows/kurtosis/**), or the workflow itself changesThis reduces CI costs and provides faster feedback by running workflows only when relevant code changes.
Comment Response
Replied to comment clarifying the RPC failures are pre-existing and recommending verification against main branch to confirm.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.