fix nil-ptr in BuildIndexWithSnapName#18248
Merged
Merged
Conversation
anacrolix
requested changes
Dec 11, 2025
anacrolix
left a comment
Contributor
There was a problem hiding this comment.
I don't think a helper is required here for the nil/interface handling. FileInfo is a struct type so you won't get any value from checking for nil on it.
I would just remove the isNil(info) check, and replace isNil(info.Type) with info.Type == nil.
I can see you're panicking because there's some kind of bad state creeping in here. A few functions up there's a call that returns the FileInfo value with a lot of checks missing. I wonder if you mean to check if FileInfo is instead the zero/empty value which would tel you it hasn't been initialized correctly.
anacrolix
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #18231 (comment)