switch RequestMore to use channels#17881
Merged
Merged
Conversation
domiwei
approved these changes
Nov 17, 2025
Member
|
@mh0lt @AskAlexSharov copy to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This potentially fixes: #17590
Or at leaste it does not make it worse. From the goroutine trace it seemed like the timers here may be deadlocked. This is based on the fact that they are all asleep in the dump, and looking at the logs at leaste one of them ought to have fired. As this is a guess and not a definitae fix I have run qa many times in repetition just to make sure it doesnt make the situation worse.
I think it also makes the code slightly more idiomatic go.