Trie: reduce cell size - by using int16 for prefix lengths#17134
Merged
Conversation
awskii
reviewed
Sep 29, 2025
| CodeHash common.Hash | ||
| Storage common.Hash | ||
| StorageLen int | ||
| StorageLen int16 |
Collaborator
Author
There was a problem hiding this comment.
actually it's hard to move from int16 to int8:
- we have code like
128 - depth - and even if i workaround it as
int8(128 - int16(depth))i still facing int overflow/underflow in many places
awskii
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
536->488bytes