optimise FindBlockNum (#15398)#15529
Merged
Merged
Conversation
ticket: #15209 - `ReadTxNumFunc` gets maxtxnum given a blockNumber...it was also used to find blockNumber given maxTxNum.. - add `TxBlockIndex` in-place of `ReadTxNumFunc` -- difference is that there's now a separate function to GetBlockNumber. Additionally: - earlier, binary search was performed over a range of block numbers, each search step queries MDBX and then fetches block from snapshot. - now, binary search is separated into two stages: first stage will binary_search in snapshots; second stage will do binary_search on MDBX.
AskAlexSharov
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ticket: #15209
ReadTxNumFuncgets maxtxnum given a blockNumber...it was also used to find blockNumber given maxTxNum..TxBlockIndexin-place ofReadTxNumFunc-- difference is that there's now a separate function to GetBlockNumber. Additionally: