Hex patricia reader#13784
Closed
shotasilagadze wants to merge 18 commits into
Closed
Conversation
Moved proof building into hex patricia READER --------- Co-authored-by: shota.silagadze <shota.silagadze@taal.com>
awskii
requested changes
Mar 17, 2025
awskii
reviewed
Mar 17, 2025
awskii
reviewed
Mar 17, 2025
13eb84e to
ad53450
Compare
ad53450 to
66fa17d
Compare
awskii
approved these changes
Mar 18, 2025
awskii
left a comment
Member
There was a problem hiding this comment.
Its fine but SHOULD be on wait until v3 stable is out.
…to hex-patricia-reader
Member
|
getWitnesses fails to generate proper response:
cc @antonis19 |
Contributor
|
I've encountered this before and most likely is a result of the account state reader in patricia trie implementation reading the wrong account state after unwind. Please take a look at the account state integrity checks I've implemented in this PR: #13412 They will tell you if the accounts in the leaf nodes of the generated witness trie are correct or not. |
Collaborator
|
@awskii need to close or not? |
Member
|
seems still easier to have only one implementation of trie with ability to switch off trie update building |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.