Erigon 3: Parallel state flushing#11300
Merged
Merged
Conversation
AskAlexSharov
approved these changes
Jul 25, 2024
This was referenced Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes effectively
FlushExtendingForkoverhead at chain tip.The reason why it works is that:
CL just needs FCU to return SUCCESS, and this promise is inherently mantained if the block has already been marked as valid.
What the PR actually do is: if we flush the fork built in NewPayload, return SUCCESS before the flushing (SUCCESS will be logically what would be returned anyway). this pushes the extra computation on Ethereum's idle block time, thus rendering it null and giving CLs more time to process attestations/blobs/etc...