feat: Add textTheme parameter to flutterNesTheme()#247
Merged
erickzanardo merged 3 commits intoMar 10, 2026
Conversation
Add an optional TextTheme parameter to allow overriding the default Press Start 2P font for non-Latin locales. Closes erickzanardo#246
erickzanardo
left a comment
Owner
There was a problem hiding this comment.
@kyungilcho can you add an entry to the CHANGELOG.md file?
Also left a very nit comment, other than that looks great! Once we address these two things I will merge a push a new version on pub!
| /// Creates a Flutter Nes [ThemeData]. | ||
| /// | ||
| /// Use [textTheme] to override the default Press Start 2P font | ||
| /// for non-Latin locales. |
Owner
There was a problem hiding this comment.
Suggested change
| /// for non-Latin locales. | |
| /// for non-Latin locales or just to use a different, custom `TextTheme`. |
Contributor
Author
|
Updated! Added the CHANGELOG entry under 0.29.0 and applied the doc comment suggestion. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #246
Adds an optional
TextTheme? textThemeparameter toflutterNesTheme().When provided, it replaces the default Press Start 2P text theme, enabling non-Latin locales to use custom pixel fonts while ensuring all internal theme derivations use the correct font.
Changes
TextTheme? textThemeparameter toflutterNesTheme()resolvedTextThemeto avoid shadowing