Skip to content

add node wallet password environment variable #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ross-weir merged 1 commit into from
Dec 28, 2023
Merged

add node wallet password environment variable #324

ross-weir merged 1 commit into from
Dec 28, 2023

Conversation

@Alesfatalis
Copy link
Contributor

@Alesfatalis Alesfatalis commented Dec 28, 2023

automatically unlocks node wallet if password is set

closes #323

@Alesfatalis Alesfatalis force-pushed the i323_automatic_wallet_unlock branch 3 times, most recently from de4fa73 to b693aa9 Compare December 28, 2023 19:59
@coveralls
Copy link

coveralls commented Dec 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7351269548

  • 0 of 50 (0.0%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 53.3%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/metrics.rs 0 3 0.0%
core/src/scans.rs 0 3 0.0%
core/src/cli_commands/bootstrap.rs 0 4 0.0%
core/src/main.rs 0 4 0.0%
core/src/oracle_config.rs 0 5 0.0%
core/src/node_interface.rs 0 8 0.0%
core/src/node_interface/node_api.rs 0 10 0.0%
core/src/api.rs 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/api.rs 1 0.0%
core/src/main.rs 1 0.0%
Totals Coverage Status
Change from base Build 7324796062: -0.4%
Covered Lines: 2003
Relevant Lines: 3758
💛 - Coveralls

@Alesfatalis Alesfatalis force-pushed the i323_automatic_wallet_unlock branch from b693aa9 to fd32d9a Compare December 28, 2023 20:07
@Alesfatalis Alesfatalis marked this pull request as ready for review December 28, 2023 20:19
ross-weir
ross-weir reviewed Dec 28, 2023
View reviewed changes
Copy link
Collaborator

@ross-weir ross-weir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, few small suggestions

@Alesfatalis
add node wallet password environment variable
4a5b92c 
- automatically unlocks node wallet if password is set
@Alesfatalis Alesfatalis force-pushed the i323_automatic_wallet_unlock branch from fd32d9a to 4a5b92c Compare December 28, 2023 21:10
@ross-weir ross-weir merged commit 30034d9 into ergoplatform:develop Dec 28, 2023
@Alesfatalis Alesfatalis deleted the i323_automatic_wallet_unlock branch December 28, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ross-weir ross-weir ross-weir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unlock node wallet if locked

3 participants

@Alesfatalis @coveralls @ross-weir