Skip to content

Fix pool active oracles and oracle health metrics lagging when pool is down #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
greenhat merged 2 commits into from
Jul 31, 2023
Merged

Fix pool active oracles and oracle health metrics lagging when pool is down #309

greenhat merged 2 commits into from
Jul 31, 2023

Conversation

@greenhat
Copy link
Member

@greenhat greenhat commented Jul 28, 2023

Close #307
Close #308

Determine oracle health and active oracles count in the pool based on the last oracle's box height rather than pool box height.

@coveralls
Copy link

coveralls commented Jul 28, 2023

Pull Request Test Coverage Report for Build 5692625648

  • 0 of 20 (0.0%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 54.448%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/metrics.rs 0 2 0.0%
core/src/api.rs 0 4 0.0%
core/src/monitor.rs 0 14 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/api.rs 2 0%
core/src/monitor.rs 3 0%
Totals Coverage Status
Change from base Build 5643433554: -0.2%
Covered Lines: 2093
Relevant Lines: 3844
💛 - Coveralls

@greenhat greenhat changed the title Fix pool and oracle health metrics Fix pool active oracles and oracle health metrics lagging when pool is down Jul 31, 2023
@greenhat greenhat merged commit ae2c7ea into develop Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pool health DOWN but active oracle count is not changed Oracle health OK but the last posted box is 65 blocks old (epoch length is 35)

3 participants

@greenhat @coveralls