Skip to content

Add ERG/BTC Datapoint Sources #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
greenhat merged 3 commits into from
Jul 24, 2023
Merged

Add ERG/BTC Datapoint Sources #304

greenhat merged 3 commits into from
Jul 24, 2023

Conversation

@sethdusek
Copy link
Collaborator

@sethdusek sethdusek commented Jul 14, 2023

No description provided.

@sethdusek sethdusek force-pushed the ergbtcdatapointsource branch from 3e24bc3 to 91e6d42 Compare July 14, 2023 04:40
@coveralls
Copy link

coveralls commented Jul 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5622633856

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.1%) to 54.633%
Files with Coverage Reduction New Missed Lines %
core/src/datapoint_source/erg_xau.rs 2 66.67%
core/src/datapoint_source/assets_exchange_rate.rs 4 50.0%
core/src/datapoint_source.rs 5 0%
core/src/datapoint_source/coingecko.rs 6 70.73%
core/src/pool_config.rs 6 66.67%
core/src/datapoint_source/bitpanda.rs 7 62.96%
core/src/datapoint_source/coincap.rs 7 62.96%
core/src/datapoint_source/predef.rs 9 0%
Totals Coverage Status
Change from base Build 5596499533: 0.1%
Covered Lines: 2093
Relevant Lines: 3831
💛 - Coveralls

@sethdusek sethdusek force-pushed the ergbtcdatapointsource branch 3 times, most recently from 9fd0bbd to 597087f Compare July 19, 2023 18:04
@sethdusek sethdusek force-pushed the ergbtcdatapointsource branch from 597087f to 5a67dc1 Compare July 19, 2023 18:22
@sethdusek sethdusek marked this pull request as ready for review July 20, 2023 00:40
sethdusek
sethdusek commented Jul 20, 2023
View reviewed changes
greenhat
greenhat requested changes Jul 20, 2023
View reviewed changes
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thank you! Please take a look at my comments.

@sethdusek sethdusek force-pushed the ergbtcdatapointsource branch from f20c112 to d6115c0 Compare July 21, 2023 13:01
@sethdusek sethdusek force-pushed the ergbtcdatapointsource branch from d6115c0 to 224e7cb Compare July 21, 2023 13:02
greenhat
greenhat approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@greenhat greenhat merged commit fa33c22 into ergoplatform:develop Jul 24, 2023
@greenhat greenhat mentioned this pull request Jul 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greenhat greenhat greenhat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sethdusek @coveralls @greenhat