Skip to content

Updates after "not found ballot boxes" on voting #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
greenhat merged 13 commits into from
Jun 28, 2023
Merged

Updates after "not found ballot boxes" on voting #292

greenhat merged 13 commits into from
Jun 28, 2023

Conversation

@greenhat
Copy link
Member

@greenhat greenhat commented Jun 22, 2023 •
edited
Loading

Close #291

Node scan for ballot token returns boxes.

Confirmed that ballot boxes from the previous update have different ergo tree (with previous update nft) due to the update process copying ergo tree from vote ballot boxes.

Todo:
- check the ballot box wrapper filters out boxes because of different ergo tree than in pool_config.yaml;

  • use ballot contract from updated pool config in update-pool command;
  • relax *BoxWrapper loading checks to accept boxes with "old" contracts;
  • restore update-pool to use update and ballot contracts from inputs in the outputs (there is a clause in both update and ballot contracts requiring the contract to remain unchanged);
  • confirm ballot contract change before merging since vote command takes ballot contract from the pool config in anticipation that ballot contract will be changed - https://github.com/ergoplatform/eips/pull/41/files#r1243427074

@coveralls
Copy link

coveralls commented Jun 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5346667199

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 22 of 41 (53.66%) changed or added relevant lines in 7 files are covered.
  • 117 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 55.039%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/box_kind/ballot_box.rs 4 5 80.0%
core/src/cli_commands/update_pool.rs 1 2 50.0%
core/src/cli_commands/vote_update_pool.rs 14 21 66.67%
core/src/main.rs 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
core/src/cli_commands/vote_update_pool.rs 11 59.3%
core/src/box_kind/ballot_box.rs 12 86.14%
core/src/main.rs 94 0.0%
Totals Coverage Status
Change from base Build 5334019994: -0.1%
Covered Lines: 2070
Relevant Lines: 3761
💛 - Coveralls

@greenhat greenhat changed the title Add debug logging during the voting process for all found ballot boxes; Fix not found ballot boxes after the update Jun 23, 2023
greenhat added 2 commits June 23, 2023 15:53
@greenhat
use ballot contract from updated pool config for new ballot boxes in …
b9c5400 
…update_pool;
@greenhat
use ballot contract from pool config in vote_update_pool,
29c269c 
use update contract from pool config in update_pool command;
ignore ergo tree in BallotBoxWrapper::new;
@greenhat greenhat force-pushed the i291-missing-ballot-token branch from 63dd71e to 29c269c Compare June 26, 2023 09:24
@greenhat greenhat changed the title Fix not found ballot boxes after the update Updates after "not found ballot boxes" on voting Jun 27, 2023
@greenhat greenhat merged commit 4b03191 into develop Jun 28, 2023
@greenhat greenhat deleted the i291-missing-ballot-token branch June 28, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

greenhat WIP
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing my ballot token on the XAU/ERG pool on testnet

3 participants

@greenhat @coveralls