Implement draft/message-redaction#2065
Conversation
Permission to use REDACT mirrors permission for 'HistServ DELETE'
slingamn
left a comment
There was a problem hiding this comment.
This is legit! It's clean and isolated and doesn't commit Ergo to any particular position in the ongoing debate.
I'd say go ahead.
| numCapabs = 33 | ||
| // length of the uint32 array that represents the bitset: | ||
| bitsetLen = 1 | ||
| bitsetLen = 2 |
Makefile
Outdated
| go install -v -ldflags "-X main.commit=$(GIT_COMMIT) -X main.version=$(GIT_TAG)" | ||
|
|
||
| build: | ||
| build: ${capdef_file} |
There was a problem hiding this comment.
I'd rather we didn't, this just slows down the build in the normal case?
There was a problem hiding this comment.
it's only a stat() call...
There was a problem hiding this comment.
(Make won't rebuild a target if a file with the same name already exists and is more recent than its dependencies)
There was a problem hiding this comment.
Oh right, I normally don't use this feature of make (I normally do 100% phony targets). I would prefer if we didn't introduce it because I don't understand it very well :-|
slingamn says it's probably not desirable, and I'm on the fence. Out of laziness, let's omit it for now, as it's not a regression compared to '/msg HistServ DELETE'.
slingamn
left a comment
There was a problem hiding this comment.
This looks good, I'll merge it if you undo the Makefile changes?
| // If this is a PM, we just removed the message from the buffer of the other party; | ||
| // now we have to remove it from the buffer of the client who sent the REDACT command |
This reverts commit 2182b1d.
Permission to use REDACT mirrors permission for 'HistServ DELETE'
Spec: ircv3/ircv3-specifications#524 (this is a variant of ircv3/ircv3-specifications#425 with only deletion/redaction, and targetmsg moved from a tag to a parameter)
Tests: progval/irctest#203
@slingamn Thoughts on this design before I add support for PMs?