Skip to content

Fix: Adjust ReferenceNamespacedSymbolsRelativeToNamespacePrefixRector to also rewrite fully-qualified references to namespaced symbols identical to a namespace prefix#303

Merged
localheinz merged 2 commits intomainfrom
fix/namespaced-symbol
Mar 16, 2026
Merged

Fix: Adjust ReferenceNamespacedSymbolsRelativeToNamespacePrefixRector to also rewrite fully-qualified references to namespaced symbols identical to a namespace prefix#303
localheinz merged 2 commits intomainfrom
fix/namespaced-symbol

Conversation

@localheinz
Copy link
Member

@localheinz localheinz commented Mar 16, 2026

This pull request

  • adds test fixtures exposing that fully-qualified references to namespaced symbols identical to a namespace prefix are not rewritten
  • adjusts ReferenceNamespacedSymbolsRelativeToNamespacePrefixRector to also rewrite fully-qualified references to namespaced symbols identical to a namespace prefix

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.95%. Comparing base (23f512c) to head (04925b5).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #303      +/-   ##
============================================
+ Coverage     87.68%   87.95%   +0.27%     
- Complexity      219      222       +3     
============================================
  Files             6        6              
  Lines           812      822      +10     
============================================
+ Hits            712      723      +11     
+ Misses          100       99       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@localheinz localheinz force-pushed the fix/namespaced-symbol branch from 8c2b6f2 to cab68f6 Compare March 16, 2026 08:41
…es to namespace prefix symbols are not rewritten
@localheinz localheinz force-pushed the fix/namespaced-symbol branch 4 times, most recently from 8181803 to 948dc8b Compare March 16, 2026 08:46
… to also rewrite fully-qualified references to namespaced symbols identical to a namespace prefix
@localheinz localheinz force-pushed the fix/namespaced-symbol branch from 948dc8b to 04925b5 Compare March 16, 2026 08:47
@localheinz localheinz changed the title Fix: Adjust ReferenceNamespacedSymbolsRelativeToNamespacePrefixRector to also rewrite fully-qualified references to namespace prefix symbols Fix: Adjust ReferenceNamespacedSymbolsRelativeToNamespacePrefixRector to also rewrite fully-qualified references to namespaced symbols identical to a namespace prefix Mar 16, 2026
@localheinz localheinz merged commit 9f2ebaa into main Mar 16, 2026
27 checks passed
@localheinz localheinz deleted the fix/namespaced-symbol branch March 16, 2026 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants