Fix discovery of @maximumDuration annotation when test-cases have no test methods#687
Merged
localheinz merged 1 commit intoergebnis:mainfrom Feb 6, 2026
Conversation
230dec9 to
cd7cbfe
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
============================================
- Coverage 63.59% 63.38% -0.21%
Complexity 135 135
============================================
Files 33 33
Lines 618 620 +2
============================================
Hits 393 393
- Misses 225 227 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
52d28c0 to
cc61a4c
Compare
localheinz
previously approved these changes
May 24, 2025
4777ea0 to
bfaa3bb
Compare
1 task
bfaa3bb to
3d341a6
Compare
localheinz
previously approved these changes
May 24, 2025
f15a1d3 to
f51937a
Compare
Contributor
Author
|
Hey @localheinz , Are you able to approve the workflow? I apologise for the revisions -- I think I exceeded some limit. The full suite of tests for all versions does not run locally for myself. I think the code changes are good, but getting the test expectations correct has been trial and error. |
Member
|
Apologies for the delay! |
f51937a to
fbf30fd
Compare
Contributor
Author
|
Heya @localheinz , Just another nudge to approve this workflow. I'm hoping I have the tests expectations correct this time 🤞 |
6884068 to
ad12e7e
Compare
ad12e7e to
8b64b88
Compare
localheinz
approved these changes
Feb 6, 2026
Member
|
Thank you, @courtney-miles - and again, I apologize for the delay! |
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a warning triggered when discovering the maximum duration for a test-case class that has no test methods.
Fixes #686