Fix discovery of @maximumDuration annotation when using data providers#675
Merged
localheinz merged 1 commit intoergebnis:mainfrom Apr 11, 2025
Merged
Conversation
Contributor
Author
|
Hi there! This is ready for review. |
6d4020b to
54b4e99
Compare
Contributor
Author
|
@localheinz could you grant me permission to launch the actions? I'd love to see how this runs on all versions. Thanks! |
29da58e to
2bd9051
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
============================================
- Coverage 58.77% 57.86% -0.91%
Complexity 135 135
============================================
Files 33 33
Lines 701 712 +11
============================================
Hits 412 412
- Misses 289 300 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks @localheinz ! I'll look into the failing checks. |
Contributor
Author
|
@localheinz I ran php-cs-fixer, which should fix most of the issues. I'm not sure what to do about the code coverage alert, since it's a one line change. |
3f73f72 to
0311b05
Compare
@maximumDuration annotation when using data providers
localheinz
previously approved these changes
Apr 11, 2025
0311b05 to
7a953e8
Compare
localheinz
previously approved these changes
Apr 11, 2025
a3e8474 to
cad955a
Compare
cad955a to
c3c5592
Compare
localheinz
approved these changes
Apr 11, 2025
Member
|
Thank you, @morgan-atproperties! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the maximumDuration annotation does not work when a test uses a PHPUnit data provider. This PR fixes discovery of the maximumDuration annotation .
Fixes #677.