Codecov Report

❌ Patch coverage is 96.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.76%. Comparing base (9cb8147) to head (322a751).
⚠️ Report is 4 commits behind head on main.

@@             Coverage Diff              @@
##               main     #396      +/-   ##
============================================
+ Coverage     64.32%   66.76%   +2.44%     
- Complexity      136      146      +10     
============================================
  Files            33       33              
  Lines           625      680      +55     
============================================
+ Hits            402      454      +52     
- Misses          223      226       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mvorisek

Can you explain what problem you are trying to solve with this and #379?

@mvorisek

No, that's #380 - this pull request here and #379 are about changing the output.

My apologies.

In this PR I improved the UX of the output. Please see the PR description. It deduplicates the global max. duration value in the output. And as coded newly, the value in the parenthesis now makes more sense in the header, as the header mentions what the value is about. This is also how https://github.com/johnkary/phpunit-speedtrap was/is coded.

@mvorisek

Perhaps it would make more sense to allow configuring the reporter?

This way everyone can use the reporter (and thus, the format of the report) of their choice.

What do you think?

PR is done and rebased on the latest main.

Perhaps it would make more sense to allow configuring the reporter?

Deduplicated/simpler to read report is better for UX. IMHO no configuration option is needed, it would only complicate the code.

@localheinz default/native PHPUnit duration formatter always shows minutes - https://github.com/sebastianbergmann/php-timer/blob/6.0.0/src/Duration.php#L81 - I tried to unify the format with this one, but the results were too complex. Then I tried to format times below 1 minute with s/ms and the results are, in my opinion, very readable and the whole output feels very natural. Wdyt?

@localheinz this is purely an UX change. I want your green light here in order to rebase. If you, for some reasons, do not want this improvement, please share the reasons with me and we can find a common ground or even close this PR. Thanks!

Apologies for the delay, @mvorisek - please rebase!

Thank you, @mvorisek!

Thank you @localheinz, very nice addition!