Skip to content

Fix: Adjust CallLikes\NoNamedArgumentRule to handle calls to constructors of variable class names#957

Merged
localheinz merged 2 commits intomainfrom
fix/class-name
Jun 23, 2025
Merged

Fix: Adjust CallLikes\NoNamedArgumentRule to handle calls to constructors of variable class names#957
localheinz merged 2 commits intomainfrom
fix/class-name

Conversation

@localheinz
Copy link
Copy Markdown
Member

@localheinz localheinz commented Jun 23, 2025

This pull request

  • add test cases using variable class names
  • adjusts CallLikes\NoNamedArgumentRule to handle calls to constructors of variable class names

Fixes #952.

@localheinz localheinz self-assigned this Jun 23, 2025
@localheinz localheinz requested a review from ergebnis-bot as a code owner June 23, 2025 16:12
@localheinz localheinz changed the title Fix: Adjust CallLikes\NoNamedArgumentRule to handle variable class names Fix: Adjust CallLikes\NoNamedArgumentRule to handle calls to constructors of variable class names Jun 23, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.42%. Comparing base (94a5249) to head (c907303).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #957   +/-   ##
=========================================
  Coverage     98.42%   98.42%           
- Complexity      309      310    +1     
=========================================
  Files            37       37           
  Lines          1268     1270    +2     
=========================================
+ Hits           1248     1250    +2     
  Misses           20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@localheinz localheinz merged commit b6ebd6d into main Jun 23, 2025
25 checks passed
@localheinz localheinz deleted the fix/class-name branch June 23, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic class name constructor with named arguments issue

2 participants