Skip to content

Enhancement: Implement InvokeParentHookMethodRule#939

Merged
localheinz merged 1 commit intomainfrom
feature/invoke-parent-method
Jun 2, 2025
Merged

Enhancement: Implement InvokeParentHookMethodRule#939
localheinz merged 1 commit intomainfrom
feature/invoke-parent-method

Conversation

@localheinz
Copy link
Member

@localheinz localheinz commented May 31, 2025

This pull request

  • implements an InvokeParentHookMethodRule, which reports an error when a hook method that overrides a hook method in a parent class does not invoke the overridden hook method in the expected order

@codecov
Copy link

codecov bot commented May 31, 2025

Codecov Report

Attention: Patch coverage is 97.49216% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.35%. Comparing base (803668e) to head (e91707e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Methods/InvokeParentHookMethodRule.php 96.49% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #939      +/-   ##
============================================
- Coverage     98.64%   98.35%   -0.29%     
- Complexity      239      304      +65     
============================================
  Files            31       37       +6     
  Lines           959     1278     +319     
============================================
+ Hits            946     1257     +311     
- Misses           13       21       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@localheinz localheinz force-pushed the feature/invoke-parent-method branch 8 times, most recently from 919c397 to cc6a9ae Compare June 2, 2025 07:55
@localheinz localheinz changed the title Enhancement: Implement InvokeParentMethodRule Enhancement: Implement InvokeParentHookMethodRule Jun 2, 2025
@localheinz localheinz force-pushed the feature/invoke-parent-method branch from cc6a9ae to 23ff5e4 Compare June 2, 2025 07:58
@localheinz localheinz marked this pull request as ready for review June 2, 2025 07:58
@localheinz localheinz requested a review from ergebnis-bot as a code owner June 2, 2025 07:58
@localheinz localheinz force-pushed the feature/invoke-parent-method branch 6 times, most recently from 3608616 to cd26012 Compare June 2, 2025 11:49
@localheinz localheinz force-pushed the feature/invoke-parent-method branch from cd26012 to e91707e Compare June 2, 2025 11:53
@localheinz localheinz merged commit a395e76 into main Jun 2, 2025
23 of 25 checks passed
@localheinz localheinz deleted the feature/invoke-parent-method branch June 2, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants