Merge pull request #394 from ergebnis/fix/condition

localheinz · web-flow · commit e1d03464e91b · 2021-11-08T14:25:29.000+01:00
Fix: Avoid comparing boolean with boolean
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
@@ -8,9 +8,6 @@
       <code>toString</code>
       <code>toString</code>
     </MixedMethodCall>
-    <RedundantIdentityWithTrue occurrences="1">
-      <code>true === $allowAbstractClasses</code>
-    </RedundantIdentityWithTrue>
   </file>
   <file src="src/Classes/NoExtendsRule.php">
     <MixedArgument occurrences="1">
diff --git a/src/Classes/FinalRule.php b/src/Classes/FinalRule.php
@@ -57,7 +57,7 @@ public function __construct(
             return $classNotRequiredToBeAbstractOrFinal;
         }, $classesNotRequiredToBeAbstractOrFinal);
 
-        if (true === $allowAbstractClasses) {
+        if ($allowAbstractClasses) {
             $this->errorMessageTemplate = 'Class %s is neither abstract nor final.';
         }
     }
@@ -87,7 +87,7 @@ public function processNode(
             return [];
         }
 
-        if (true === $this->allowAbstractClasses && $node->isAbstract()) {
+        if ($this->allowAbstractClasses && $node->isAbstract()) {
             return [];
         }
 

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public function __construct(`
`57`	`57`	`return $classNotRequiredToBeAbstractOrFinal;`
`58`	`58`	`}, $classesNotRequiredToBeAbstractOrFinal);`
`59`	`59`
`60`		`- if (true === $allowAbstractClasses) {`
	`60`	`+ if ($allowAbstractClasses) {`
`61`	`61`	`$this->errorMessageTemplate = 'Class %s is neither abstract nor final.';`
`62`	`62`	`}`
`63`	`63`	`}`
`@@ -87,7 +87,7 @@ public function processNode(`
`87`	`87`	`return [];`
`88`	`88`	`}`
`89`	`89`
`90`		`- if (true === $this->allowAbstractClasses && $node->isAbstract()) {`
	`90`	`+ if ($this->allowAbstractClasses && $node->isAbstract()) {`
`91`	`91`	`return [];`
`92`	`92`	`}`
`93`	`93`