Ensure "dev-" prefix and "-dev" suffix is used correctly#1055
Merged
localheinz merged 8 commits intoergebnis:mainfrom Apr 10, 2025
Merged
Ensure "dev-" prefix and "-dev" suffix is used correctly#1055localheinz merged 8 commits intoergebnis:mainfrom
localheinz merged 8 commits intoergebnis:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
============================================
+ Coverage 97.26% 97.32% +0.06%
- Complexity 203 209 +6
============================================
Files 32 32
Lines 840 861 +21
============================================
+ Hits 817 838 +21
Misses 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
localheinz
approved these changes
Apr 10, 2025
Member
|
Thank you, @fredden! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In composer/composer#11770 (comment), it was stated that a
dev-prefix means something different than a-devsuffix. This came up because a user was treating these as interchangeable when they aren't. This pull request ensures that a prefix is used for "non-numeric branches" whereas a suffix is used for "numeric branches".While working on this, I noticed a bug in the "remove leading v" code. I've fixed that here (in a separate commit), but I can equally open a separate pull request if you would prefer.
Follows #1027