Merge pull request #599 from ergebnis/fix/rename

localheinz · web-flow · commit 38148ffc4f6b · 2021-12-29T11:55:03.000+01:00
Fix: Rename parameter and field
diff --git a/src/Format/NewLine.php b/src/Format/NewLine.php
@@ -18,23 +18,23 @@
 
 final class NewLine
 {
-    private string $string;
+    private string $value;
 
-    private function __construct(string $string)
+    private function __construct(string $value)
     {
-        $this->string = $string;
+        $this->value = $value;
     }
 
     /**
      * @throws Exception\InvalidNewLineStringException
      */
-    public static function fromString(string $string): self
+    public static function fromString(string $value): self
     {
-        if (1 !== \preg_match('/^(?>\r\n|\n|\r)$/', $string)) {
-            throw Exception\InvalidNewLineStringException::fromString($string);
+        if (1 !== \preg_match('/^(?>\r\n|\n|\r)$/', $value)) {
+            throw Exception\InvalidNewLineStringException::fromString($value);
         }
 
-        return new self($string);
+        return new self($value);
     }
 
     public static function fromJson(Json $json): self
@@ -48,6 +48,6 @@ public static function fromJson(Json $json): self
 
     public function toString(): string
     {
-        return $this->string;
+        return $this->value;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -18,23 +18,23 @@`
`18`	`18`
`19`	`19`	`final class NewLine`
`20`	`20`	`{`
`21`		`- private string $string;`
	`21`	`+ private string $value;`
`22`	`22`
`23`		`- private function __construct(string $string)`
	`23`	`+ private function __construct(string $value)`
`24`	`24`	`{`
`25`		`- $this->string = $string;`
	`25`	`+ $this->value = $value;`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`/**`
`29`	`29`	`* @throws Exception\InvalidNewLineStringException`
`30`	`30`	`*/`
`31`		`- public static function fromString(string $string): self`
	`31`	`+ public static function fromString(string $value): self`
`32`	`32`	`{`
`33`		`- if (1 !== \preg_match('/^(?>\r\n\|\n\|\r)$/', $string)) {`
`34`		`- throw Exception\InvalidNewLineStringException::fromString($string);`
	`33`	`+ if (1 !== \preg_match('/^(?>\r\n\|\n\|\r)$/', $value)) {`
	`34`	`+ throw Exception\InvalidNewLineStringException::fromString($value);`
`35`	`35`	`}`
`36`	`36`
`37`		`- return new self($string);`
	`37`	`+ return new self($value);`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`public static function fromJson(Json $json): self`
`@@ -48,6 +48,6 @@ public static function fromJson(Json $json): self`
`48`	`48`
`49`	`49`	`public function toString(): string`
`50`	`50`	`{`
`51`		`- return $this->string;`
	`51`	`+ return $this->value;`
`52`	`52`	`}`
`53`	`53`	`}`