Enhancement: Apply lax validation to composer.json#416
Merged
ergebnis-bot merged 1 commit intomasterfrom Apr 30, 2020
Merged
Conversation
4 tasks
305d781 to
cb6f0c0
Compare
Codecov Report
|
localheinz
commented
Apr 30, 2020
| $io, | ||
| $composerFile | ||
| ); | ||
| } catch (\Exception $exception) { |
Member
Author
There was a problem hiding this comment.
This useless because Factory::createComposer() is run earlier already - we never even get here.
localheinz
commented
Apr 30, 2020
| '<error>%s</error>', | ||
| $exception->getMessage() | ||
| )); | ||
| } catch (Normalizer\Exception\OriginalInvalidAccordingToSchemaException $exception) { |
Member
Author
There was a problem hiding this comment.
We'll never get here either, keeping it only for consistency.
ergebnis-bot
approved these changes
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
composer.jsonFixes #349.
Replaces #352.