Fix: Reject blank or empty string when attempting to create a File#1124
Merged
localheinz merged 2 commits intomainfrom Dec 24, 2025
Merged
Fix: Reject blank or empty string when attempting to create a File#1124localheinz merged 2 commits intomainfrom
string when attempting to create a File#1124localheinz merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1124 +/- ##
============================================
+ Coverage 71.56% 71.92% +0.35%
- Complexity 97 99 +2
============================================
Files 17 18 +1
Lines 313 317 +4
============================================
+ Hits 224 228 +4
Misses 89 89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Filestring when attempting to create a File
e7da7db to
ddb243e
Compare
staabm
reviewed
Dec 24, 2025
| } | ||
|
|
||
| /** | ||
| * @throws Exception\InvalidFile |
Contributor
There was a problem hiding this comment.
you might add @phpstan-assert non-empty-string $value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
ergebnis/data-providerstrings when attempting to create aFile