In the Griefing contract, the function getPunishment exists to show the amount of punishment that is achievable for a given amount of cost.

The function returns incorrect values for two reasons:

1. The punishment amount is not limited by the maximum amount staked.
2. The getPunishment function uses multiplication but the actual getCost function which is used employes division. Due to quantization effects, division is not the inverse of multiplication. (e.g. 1÷3×3 ≠ 1)

Recommendation: remove the getPunishment function entirely because it can never be accurate.

References:

• erasure-protocol/contracts/modules/Griefing.sol

  Line 91 in 4a3d98c

  function getPunishment(uint256 ratio, uint256 cost, RatioType ratioType) public pure returns(uint256 punishment) {