Regarding the CountdownGriefingEscrow and CountdownGriefing contracts.

The documentation identifies that the staker or counterparty must approve [ERC-20] tokens to send. This is not necessarily correct. The implementation is that if the function is called by the operator then the operator’s funds are used.

Recommendation: decide which specification is correct, does the operator have authority to spend tokens on behalf of stakers and counterparties, or not? Update documentation and/or implementation as appropriate.

References:

• One example in CountdownGriefing.sol:

  erasure-protocol/contracts/agreements/CountdownGriefing.sol

  Line 86 in 4a3d98c

  /// - requires the staker to have previously approved the agreement for the amount of tokens

• One example in CountdownGriefingEscrow.sol:

  erasure-protocol/contracts/escrows/CountdownGriefingEscrow.sol

  Line 137 in 4a3d98c

  /// - requires the seller to have previously approved the escrow to transfer the amount of tokens