Skip to content

fix RUSTSEC-2020-0071#69

Merged
epwalsh merged 4 commits into
epwalsh:mainfrom
hanabi1224:fix-rustsec-2020-0071
Feb 25, 2023
Merged

fix RUSTSEC-2020-0071#69
epwalsh merged 4 commits into
epwalsh:mainfrom
hanabi1224:fix-rustsec-2020-0071

Conversation

@hanabi1224

@hanabi1224 hanabi1224 commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

This PR tries to fix https://rustsec.org/advisories/RUSTSEC-2020-0071 by removing time 0.1 from dependency tree

@epwalsh

epwalsh commented Feb 24, 2023

Copy link
Copy Markdown
Owner

Looking at the build logs it looks like time is still included?

@hanabi1224

Copy link
Copy Markdown
Contributor Author

@epwalsh time v0.3 is still being used, only the problematic time v0.1 is removed

@epwalsh epwalsh left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just one minor comment

Comment thread CHANGELOG.md Outdated
### Changed

- Consolidated HTTP error variants into a single variant, `HttpError`, which sources directly from the underlying `reqwest::Error` for better error messages.
- Fixed `RUSTSEC-2020-0071`

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this up to the "Unreleased" section?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@epwalsh epwalsh left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@epwalsh epwalsh enabled auto-merge (squash) February 25, 2023 01:13
@epwalsh epwalsh merged commit 4d76ca9 into epwalsh:main Feb 25, 2023
@hanabi1224 hanabi1224 deleted the fix-rustsec-2020-0071 branch February 25, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants