Include git lightweight tags for version detection#58
Merged
epsilonrt merged 1 commit intoepsilonrt:masterfrom Sep 25, 2024
Merged
Include git lightweight tags for version detection#58epsilonrt merged 1 commit intoepsilonrt:masterfrom
epsilonrt merged 1 commit intoepsilonrt:masterfrom
Conversation
Contributor
Author
|
@epsilonrt Do you see a chance to look at this PR? |
Contributor
|
@epsilonrt I ran into similar issue using |
Contributor
|
@epsilonrt Thanks. Probably a good time to push a new version tag (Eg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitVersion.cmake uses
git describeto detect the application version.By default, Git reads only annotated tags. The git repo currently contains a few version tags, but they're all lighweight tags, none of them is annotated. Thus, the version detection fails and the resulting version (
mbpoll -V) is always1.0-0.Git may be advised to handle lightweight tags by setting the argument
--tags. This results in a proper version, e.g.1.4-11for the current master branch (1968de6).