Skip to content

Support for ratelimit-reset #165

@ioggstream

Description

@ioggstream

I expect

The ratelimit service to expose the data required to populate the x-ratelimit-reset header

Instead

They are not exposed

Reproduce

When I run

git clone https://github.com/ioggstream/envoy-ratelimit-quickstart
cd envoy-ratelimit-quickstart
docker-compose up -d
curl -i http://localhost:8080/service/1

I get

HTTP/1.1 200 OK
content-type: text/html; charset=utf-8
content-length: 91
server: envoy
date: Fri, 07 Aug 2020 15:15:03 GMT
x-envoy-upstream-service-time: 11
x-ratelimit-limit: 50, 50;w=60
x-ratelimit-remaining: 49
x-ratelimit-reset: 0

Hello from behind Envoy (service 2)! hostname: 5eac71206ff9 resolvedhostname: 192.168.32.2

I expect

x-ratelimit-reset: 49

Instead

x-ratelimit-reset: 0

Note

Thanks for implementing ratelimit draft in envoy :D

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions