Skip to content

Fix runtime config hot reload #150

@ysawa0

Description

@ysawa0

Relates to #132

I'm not sure if the current implementation is intended but I've noticed config hot reloading is not working as expected (locally on Docker and with k8s ConfigMaps)

After some debugging I traced the issue down to — SymLinkRefresher watches only the base runtime path instead of RuntimePath/RuntimeSubdirectory/config
https://github.com/lyft/goruntime/blob/master/loader/symlink_refresher.go#L10

To fix this I would like to:

  1. Update goruntime package being used to latest. From 0.2.1 ⇒ 0.2.4
  1. After 1, I'd like to switch SymLink to DirectoryRefresher in https://github.com/envoyproxy/ratelimit/blob/master/src/server/server_impl.go#L172-L176 and update the paths being passed in so hot reload works.

If Lyft maintainers want to chime in and say if it's working as intended for them, I can add this as a configurable option instead of permanent change.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions