Skip to content

Remove all instances of using DebugString in tests to compare protos#890

Merged
mum4k merged 1 commit intoenvoyproxy:mainfrom
dubious90:remove_debug_string
Aug 5, 2022
Merged

Remove all instances of using DebugString in tests to compare protos#890
mum4k merged 1 commit intoenvoyproxy:mainfrom
dubious90:remove_debug_string

Conversation

@dubious90
Copy link
Copy Markdown
Contributor

@dubious90 dubious90 commented Aug 5, 2022

Fixes #433

Signed-off-by: Nathan Perry nbperry@google.com

@dubious90 dubious90 force-pushed the remove_debug_string branch 2 times, most recently from e23ea52 to 66f0e5d Compare August 5, 2022 01:17
protos.

Signed-off-by: Nathan Perry <nbperry@google.com>
@dubious90 dubious90 force-pushed the remove_debug_string branch from 66f0e5d to f6d1872 Compare August 5, 2022 01:19
@dubious90 dubious90 requested a review from tomjzzhang August 5, 2022 04:51
@dubious90 dubious90 marked this pull request as ready for review August 5, 2022 04:51
@dubious90 dubious90 added the waiting-for-review A PR waiting for a review. label Aug 5, 2022
@mum4k mum4k merged commit f8b322e into envoyproxy:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add safe proto diff helper

2 participants