Skip to content

Update Envoy to 74d5ef8 (Aug 30th 2021).#740

Merged
mum4k merged 6 commits intoenvoyproxy:mainfrom
mum4k:envoy-update
Aug 31, 2021
Merged

Update Envoy to 74d5ef8 (Aug 30th 2021).#740
mum4k merged 6 commits intoenvoyproxy:mainfrom
mum4k:envoy-update

Conversation

@mum4k
Copy link
Copy Markdown
Collaborator

@mum4k mum4k commented Aug 31, 2021

mum4k added 5 commits August 30, 2021 23:48
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
@mum4k mum4k requested a review from dubious90 August 31, 2021 03:54
@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Aug 31, 2021
dubious90
dubious90 previously approved these changes Aug 31, 2021
Signed-off-by: Jakub Sobon <mumak@google.com>
Copy link
Copy Markdown
Contributor

@dubious90 dubious90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth updating this line in MAINTAINERS.md?

If the PR ends up modifying any CLI arguments, execute tools/update_cli_readme_documentation.sh --mode fix to regenerate the portion of our documentation that captures the CLI help output. This will prevent a CI failure.

I feel like the easy assumption is that this is about the nighthawk client CLI, so we should reference that it could be other CLIs (e.g. test server) to save future developers consternation.

@mum4k
Copy link
Copy Markdown
Collaborator Author

mum4k commented Aug 31, 2021

Documentation updated in #741.

@mum4k mum4k merged commit 3251ec5 into envoyproxy:main Aug 31, 2021
@mum4k mum4k deleted the envoy-update branch August 31, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants