Update Envoy to ff3b5e3 (March 22, 2021)#662
Merged
mum4k merged 4 commits intoenvoyproxy:mainfrom Mar 23, 2021
Merged
Conversation
Pull latest into my fork
sync to latest
update to master
Signed-off-by: Nathan Perry <nbperry@google.com>
oschaaf
approved these changes
Mar 22, 2021
| output.results()[0].execution_start()), | ||
| options_->scheduled_start().value().time_since_epoch().count()); | ||
| std::chrono::duration_cast<std::chrono::nanoseconds>( | ||
| options_->scheduled_start().value().time_since_epoch()) |
Member
There was a problem hiding this comment.
Ugh :/ this must have been annoying to figure out.. is this clang vs gcc?
Contributor
Author
There was a problem hiding this comment.
This one actually wasn't too bad! Reading chrono duration documentation wasn't super fun though.
I assume this is clang vs gcc or something like that? Honestly, I didn't figure this out. It was broken on my computer but not in docker, so it's something like that, but I didn't investigate what the actual difference was... sorry.
mum4k
approved these changes
Mar 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required changes:
Other necessary changes not necessarily caused by update