Stats: Hdr histogram serialization/deserialization#623
Merged
mum4k merged 2 commits intoenvoyproxy:mainfrom Feb 10, 2021
Merged
Stats: Hdr histogram serialization/deserialization#623mum4k merged 2 commits intoenvoyproxy:mainfrom
mum4k merged 2 commits intoenvoyproxy:mainfrom
Conversation
Being able to serialize and deserialize statistics serves several goals: - Allow over-the-wire transportation in horizontally scaled setups. - Facilitate storage of high res data. - Could be used as a means to decouple our workers from the main thread, by avoiding reliance on a shared process namespace to merge statistics. (not a goal right now) This adds an abstraction to Statistic, implements it for HdrHistogram, and adds some tests. Part of horizontal scaling effort, split out from: Split out from https://github.com/oschaaf/nighthawk/tree/horizontal-scaling Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Collaborator
|
@jiajunye please review and assign back to me once done. |
Contributor
|
lgtm |
mum4k
requested changes
Feb 9, 2021
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
mum4k
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Being able to serialize and deserialize statistics serves several goals:
by avoiding reliance on a shared process namespace to merge statistics.
(not a goal right now)
This adds an abstraction to Statistic, implements it for HdrHistogram, and
adds some tests.
Part of horizontal scaling effort, split out from:
Split out from https://github.com/oschaaf/nighthawk/tree/horizontal-scaling
Signed-off-by: Otto van der Schaaf ovanders@redhat.com