Signal handler: don't fire on destruction#602
Merged
mum4k merged 2 commits intoenvoyproxy:masterfrom Jan 12, 2021
Merged
Conversation
Fixes a bug observed while working on horizontal scaling support: SignalHandler would fire on destruction. Fix & add tests. Note: pre-emptive, I don't think this is an issue in the current state of master. But some of the CI errors in envoyproxy#600 seemed familiar and hopefully merging this in there helps. (Split out from https://github.com/oschaaf/nighthawk/tree/horizontal-scaling) /cc @eric846 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Collaborator
|
@qqustc please review and assign back to me once done. |
qqustc
previously approved these changes
Jan 8, 2021
mum4k
previously approved these changes
Jan 8, 2021
Collaborator
mum4k
left a comment
There was a problem hiding this comment.
Looks good, please address outstanding comments before we merge this in.
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
approved these changes
Jan 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug observed while working on horizontal scaling support:
SignalHandler would fire on destruction.
Fix & add tests.
Note: pre-emptive, I don't think this is an issue in the current
state of master. But some of the CI errors in #600 seemed familiar
and hopefully merging this in there helps.
(Split out from https://github.com/oschaaf/nighthawk/tree/horizontal-scaling)
/cc @eric846
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com