Deprecate Envoy API v2 primitives in configuration for our Envoy filters.#588
Merged
mum4k merged 6 commits intoenvoyproxy:masterfrom Dec 8, 2020
mum4k:filter-api-v2-to-v3
Merged
Deprecate Envoy API v2 primitives in configuration for our Envoy filters.#588mum4k merged 6 commits intoenvoyproxy:masterfrom mum4k:filter-api-v2-to-v3
mum4k merged 6 commits intoenvoyproxy:masterfrom
mum4k:filter-api-v2-to-v3
Conversation
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
@jiajunye please review and assign back to me once done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new field
v3_response_headersalongside the old v2response_headersinapi/server/response_options.protoand marks the old field as deprecated. The old field retains its functionality for backward compatibility.Since these are repeated fields, we cannot use a oneof. Instead validation is added to ensure the filters report an error on configuration that has both the v2 and the v3 fields set.
Envoy::EnvoyExceptionis thrown on validation errors to comply with theEnvoy::Server::Configuration::NamedHttpFilterConfigFactoryinterface.Also:
response_options.protoalphabetically.http_dynamic_delay_filter_integration_test.cc.Works on #580.
Signed-off-by: Jakub Sobon mumak@google.com